Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create license file #153

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Create license file #153

merged 1 commit into from
Aug 24, 2018

Conversation

mcgege
Copy link
Member

@mcgege mcgege commented Aug 23, 2018

Standard Apache 2.0 license based on the github template

@mcgege
Copy link
Member Author

mcgege commented Aug 23, 2018

See #151

timstoop
timstoop approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@timstoop timstoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm now a member, can I just merge the stuff that I'm okay with (aside from my own PRs obviously) or are there other rules to follow?

@mcgege
Copy link
Member Author

mcgege commented Aug 24, 2018

@timstoop I fully support that you merge what is okay from your point of view ... for me it's important that the changes are so generic that all distros as in metadata.json continue to be supported (or include the specialities of those distros).
Although I see myself as a linux expert, I don't fully understand the impact of the queued PRs (that's why it takes some time for me to review them - and I do this in my free time) ... but I try to test "manually" as much as possible to get a better understanding of the changes.

@timstoop timstoop merged commit e93bcf9 into dev-sec:master Aug 24, 2018
@mcgege mcgege deleted the license branch September 7, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timstoop timstoop timstoop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcgege @timstoop