Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency #184

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Add missing dependency #184

merged 1 commit into from
Feb 6, 2019

Conversation

theosotr
Copy link
Contributor

@theosotr theosotr commented Feb 5, 2019

This commit adds a missing dependency between Package[pam-passwdqc] and
File[/usr/share/pam-configs/passwdqc].

Specifically, it fixes non-determinism. This is what I get if Puppet processes resources in the erroneous order.

Error: /Stage[main]/Os_hardening::Pam/File[/usr/share/pam-configs/passwdqc]/ensure: change from absent to file failed: Could not set 'file' on ensure: No such file or directory @ dir_s_mkdir - /usr/share/pam-configs/passwdqc20190205-73-b7g10a.lock at /etc/puppet/code/modules/os_hardening/manifests/pam.pp:71
Notice: /Stage[main]/Os_hardening::Pam/Exec[update-pam]: Dependency File[/usr/share/pam-configs/passwdqc] has failures: true
Notice: /Stage[main]/Os_hardening::Pam/Exec[update-pam]: Dependency File[/usr/share/pam-configs/tally2] has failures: true
Warning: /Stage[main]/Os_hardening::Pam/Exec[update-pam]: Skipping because of failed dependencies
Notice: /Stage[main]/Os_hardening::Pam/Package[pam-passwdqc]/ensure: created

This commit adds a missing dependency between Package[pam-passwdqc] and
File[/usr/share/pam-configs/passwdqc].

Signed-off-by: Thodoris Sotiropoulos <theosotr@aueb.gr>
@mcgege
Copy link
Member

mcgege commented Feb 6, 2019

@theosotr Thanks a lot!

@mcgege mcgege merged commit 3481d09 into dev-sec:master Feb 6, 2019
@theosotr theosotr deleted the fix branch February 6, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants