Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIS: Fix permissions on home cron and log dirs #203

Merged
merged 11 commits into from
Jun 16, 2019

Conversation

PenguinFreeDom
Copy link
Contributor

This fixes a few CIS permission checks.

Signed-off-by: PenguinFreeDom <ansa@sdu.dk>
@mcgege
Copy link
Member

mcgege commented May 28, 2019

@PenguinFreeDom Thanks for your PR! To fix the Travis CI errors, please have a look at the log output. And you don't have to open a new PR for this, just push your changes to your branch (this will automatically be visible here).

Signed-off-by: PenguinFreeDom <ansa@sdu.dk>
Signed-off-by: PenguinFreeDom <ansa@sdu.dk>
Signed-off-by: PenguinFreeDom <ansa@sdu.dk>
@PenguinFreeDom
Copy link
Contributor Author

@PenguinFreeDom Thanks for your PR! To fix the Travis CI errors, please have a look at the log output. And you don't have to open a new PR for this, just push your changes to your branch (this will automatically be visible here).

Hi I corrected the syntax, but i still get errors in the Integration checks......it dose not look like its my code though, but rather a docker error.

@mcgege mcgege mentioned this pull request May 29, 2019
@mcgege
Copy link
Member

mcgege commented May 29, 2019

@PenguinFreeDom Please rebase, Travis CI should work now

manifests/init.pp Outdated Show resolved Hide resolved
manifests/minimize_access.pp Outdated Show resolved Hide resolved
manifests/minimize_access.pp Show resolved Hide resolved
Copy link
Member

@mcgege mcgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I'll test it the next days.
One last thing: Please add your new options with a small info to the README file

@mcgege mcgege merged commit f532da2 into dev-sec:master Jun 16, 2019
@mcgege
Copy link
Member

mcgege commented Jun 16, 2019

@PenguinFreeDom Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants