Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some applications require different setting for icmp_ratelimit #204

Merged
merged 1 commit into from
May 29, 2019
Merged

Some applications require different setting for icmp_ratelimit #204

merged 1 commit into from
May 29, 2019

Conversation

tuxmea
Copy link
Contributor

@tuxmea tuxmea commented May 29, 2019

e.g. check_mk
make icmp_ratelimit a parameter

@tuxmea
Copy link
Contributor Author

tuxmea commented May 29, 2019

kitchen has issues with docker:

unknown flag: --type
See 'docker --help'.

@mcgege
Copy link
Member

mcgege commented May 29, 2019

kitchen has issues with docker:
unknown flag: --type
See 'docker --help'.

@tuxmea Thanks for the PR ... but before I can look into it seems like I have to solve this Travis problem. This docker error message was already there a year before, it doesn't seem to be the problem ... there's now a Could not resolve the dependencies errror in the build, I'll try to find the error.

@mcgege mcgege mentioned this pull request May 29, 2019
@tuxmea tuxmea closed this May 29, 2019
@tuxmea tuxmea reopened this May 29, 2019
e.g. check_mk
make icmp_ratelimit a parameter

Signed-off-by: Martin Alfke <ma@example42.com>
@mcgege
Copy link
Member

mcgege commented May 29, 2019

@tuxmea Please rebase, Travis CI should work now

@tuxmea
Copy link
Contributor Author

tuxmea commented May 29, 2019

@mcgege green tests, ready to merge. Many thanks for the fast fix.

@mcgege mcgege merged commit fb4f64e into dev-sec:master May 29, 2019
@tuxmea tuxmea deleted the parameterize_icmp_ratelimit branch May 30, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants