Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix + switch for arp_ignore #256

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Fix + switch for arp_ignore #256

merged 1 commit into from
Dec 28, 2020

Conversation

mcgege
Copy link
Member

@mcgege mcgege commented Dec 27, 2020

revert arp_ignore to old default (=1) and introduce new switch arp_ignore_samenet to enable the more secure value 2

Signed-off-by: Michael Geiger info@mgeiger.de

@mcgege
revert arp_ignore to old default (=1) and introduce new switch
a573159 
arp_ignore_samenet to enable the more secure value 2

Signed-off-by: Michael Geiger <info@mgeiger.de>
This was referenced Dec 27, 2020
Closed
Merged
@mcgege mcgege requested a review from schurzi December 27, 2020 15:03
schurzi
schurzi approved these changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely happy with the variable name. I think a better name would be arp_restricted_samenet to show the connecton to the exsiting variable arp_restricted.

In principle this looks ok.

@mcgege mcgege merged commit bc05c97 into master Dec 28, 2020
@mcgege mcgege deleted the arp-ignore branch December 28, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schurzi schurzi schurzi approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcgege @schurzi