Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_max_files_warnings (#279) #280

Merged
merged 2 commits into from
Jul 18, 2021
Merged

Conversation

earthgecko
Copy link
Contributor

  • Allow user to disable puppet warnings related to max_files exceeding default of 1000 if they choose to

* Allow user to disable puppet warnings related to max_files exceeding default of 1000 if they choose to
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.81%. Comparing base (47f336f) to head (03e797c).
Report is 44 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files           4        4           
  Lines          49       49           
=======================================
  Hits           20       20           
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@earthgecko
Copy link
Contributor Author

I cannot say why the puppet5 tests are failing.

@mcgege
Copy link
Member

mcgege commented Jul 18, 2021

@earthgecko Looks like this max_files option was not present in Puppet v5 ... but as this version is EOL since beginning of this year, I'll remove those tests now. When done I'll trigger you and then please merge that ...

@mcgege
Copy link
Member

mcgege commented Jul 18, 2021

Tests changed, please merge latest changes into your branch and retry

@earthgecko
Copy link
Contributor Author

@mcgege thanks, merged, hopefully that should do it.

@mcgege
Copy link
Member

mcgege commented Jul 18, 2021

Looks good, many thanks for your PR!

@earthgecko
Copy link
Contributor Author

@mcgege no thanks needed. Thank you for maintaining the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants