Make the sysctl setting 'rp_filter' configurable #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcgege thanks for this PR! Makes sense from my view @bitvijays your turn :) |
artem-sidorenko
approved these changes
Jun 19, 2017
|
@artem-sidorenko Looks good to me too. However, Travis is failing because of the "Rakefile:1:1: W: Lint/ScriptPermission: Script file Rakefile doesn't have execute permission." Possible for you to have a quick look? Cheers, |
|
@bitvijays GH-85 has fixes for rubocop |
|
@mcgege master is fixed now, could you please rebase our PR on the latest master? |
|
@artem-sidorenko rebase done |
|
@mcgege thanks! @bitvijays looks good to me, feel free to merge if you like |
|
Thank you @mcgege for your contribution. It's much appreciated. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I need to disable the reverse path filter on some nodes this should be configurable in my opinion