Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making rubocop happy #85

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Making rubocop happy #85

merged 1 commit into from
Jun 19, 2017

Conversation

artem-sidorenko
Copy link
Member

No description provided.

Copy link
Contributor

@bitvijays bitvijays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artem-sidorenko Looks alright to me. I just referred https://github.com/bbatsov/rubocop/blob/master/manual/cops_layout.md and cops_style.md.

Have they just changed it the Dotposition from Style to Layout?

Could you please help in understanding the Rakefile change?

@artem-sidorenko
Copy link
Member Author

@bitvijays

Have they just changed it the Dotposition from Style to Layout?

yes, it was changed in some rubocop version, however I can't tell you when :)

Could you please help in understanding the Rakefile change?

The shebang is here not really required: you invoke the Rakefile commands via rake command, e.g. rake lint. So rake reads the Rakefile and takes the actions. I'm even not sure if execution of Rakefile like ./Rakefile lint in the script way will work (if rake supports that)

@bitvijays
Copy link
Contributor

Cool. Thanks @artem-sidorenko Please go ahead with the merge :) :)

@artem-sidorenko
Copy link
Member Author

@bitvijays feel free to merge as well, you should have the according rights

@artem-sidorenko artem-sidorenko merged commit 041327f into dev-sec:master Jun 19, 2017
@artem-sidorenko artem-sidorenko deleted the fixci branch June 19, 2017 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants