Skip to content

Commit bdecbd0

Browse files
Merge pull request #92 from devcontainers/samruddhikhandale/fix-regression
fix bug: incorrect 'latest' tag for base image
2 parents 81cfbdd + 5ba934b commit bdecbd0

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

build/src/push.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,6 @@ async function pushImage(definitionId, repo, release, updateLatest,
132132
const workingDir = path.resolve(dotDevContainerPath, context);
133133
const imageNameParams = imageNamesWithVersionTags.reduce((prev, current) => prev.concat(['--image-name', current]), []);
134134

135-
// Do not build and push the "latest" tag when pushing the "dev" images
136-
if (configUtils.getVersionFromRelease(release, definitionId) !== 'dev' || !pushImages) {
137-
imageNameParams.push('--image-name', imageName);
138-
}
139-
140135
const spawnOpts = { stdio: 'inherit', cwd: workingDir, shell: true };
141136
await asyncUtils.spawn('devcontainer', [
142137
'build',

0 commit comments

Comments
 (0)