dotnet: improve dev-certs instructions #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samruddhikhandale
requested changes
Jun 18, 2024
chrmarti
previously approved these changes
Jun 19, 2024
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
|
Thanks for the reviews @samruddhikhandale @chrmarti I applied the suggestions. Can you review again? |
samruddhikhandale
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the README for dotnet with a better way to manage HTTPS development certificates for ASP.NET Core.
Previously, it recommended a solution that did not work well in team or open source environments, as it required manual steps, and the solution carried a risk of unintended password disclosure.
I added a solution which does not require manual steps, nor does it have any risk of leaking passwords.
I did not remove the old instructions, but I did add a warning to avoid using it for shared projects.