Skip to content

Conversation

@Kaniska244
Copy link
Contributor

@Kaniska244 Kaniska244 commented Dec 31, 2024

Ref: #90

Devcontainer name

Ruby

Description

This pr adds 3.4 latest ruby version to the supported versions list in ruby image.

Changelog

  • Changes are there in manifest.json and readme.md file for ruby image to add support to latest 3.4 ruby version.

Checklist

  • Checked that applied changed work as expected

@Kaniska244 Kaniska244 marked this pull request as ready for review December 31, 2024 10:28
@Kaniska244 Kaniska244 requested a review from a team as a code owner December 31, 2024 10:28
@ghost
Copy link

ghost commented Jan 6, 2025

wow Finally !!!!

Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! However, the Dockerfile also needs to be updated with a reference to 3.4

Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the Dockerfile! There's a small error that needs to be fixed and I think we're good to go

@ddoyle2017 ddoyle2017 merged commit 6d7c437 into devcontainers:main Jan 9, 2025
2 checks passed
@Kaniska244 Kaniska244 deleted the Ruby_3.4_Upgrade branch January 10, 2025 04:33
@cgrothaus
Copy link

The docker image for 3.4 is not yet published (https://mcr.microsoft.com/en-us/artifact/mar/devcontainers/ruby/tags only has dev-3.4). When will this happen?
(Sorry if I am asking questions that would better be asked somewhere else – I don't know how this is all connected).

@ashkulz
Copy link

ashkulz commented Feb 28, 2025

@ddoyle2017 I can see dev-3.4 tag being published but not 3.4 -- do you know when it'll get published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants