Skip to content

[Ruby]- EOL v3.1 changes #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

[Ruby]- EOL v3.1 changes #1361

merged 4 commits into from
Mar 28, 2025

Conversation

@Kaniska244
Copy link
Contributor

@Kaniska244 Kaniska244 commented Mar 27, 2025 •
edited
Loading

Ref: #90

Devcontainer Image:

  • Ruby

Description of changes:

  • Changes corresponding to Ruby v3.1 EOL

Changelog:

  • Change in manifest.json & readme files to remove ruby 3.1 references

Checklist:

  • Checked that applied changes work as expected

@Kaniska244 Kaniska244 marked this pull request as ready for review March 27, 2025 13:21
@Kaniska244 Kaniska244 requested a review from a team as a code owner March 27, 2025 13:21
ddoyle2017
ddoyle2017 requested changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Before we merge this in, I think you need to remove references to 3.1 in the src/ruby/.devcontainer/Dockerfile

@Kaniska244
Copy link
Contributor Author

Kaniska244 commented Mar 28, 2025

Changes look good! Before we merge this in, I think you need to remove references to 3.1 in the src/ruby/.devcontainer/Dockerfile

Hi @ddoyle2017 ,

Thank you for pointing it out. I had missed that. Its corrected now. Would you kindly have a look and let me know in case of any further concerns.

With Regards,
Kaniska

@ddoyle2017 ddoyle2017 merged commit aebe655 into devcontainers:main Mar 28, 2025
2 checks passed
@Kaniska244 Kaniska244 deleted the Ruby_3.1_EOL branch March 28, 2025 15:27
@ddoyle2017 ddoyle2017 mentioned this pull request May 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddoyle2017 ddoyle2017 ddoyle2017 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kaniska244 @ddoyle2017