[miniconda] Refactor Dockerfile to sync with anaconda devcontianer
#741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Additional info: Before changes REPOSITORY TAG IMAGE ID CREATED SIZE
vsc-miniconda-62fb3f29e4a9189b28ec2500ae0bbb7d3c31676a6ead82d187ffd0f867dab9c6 latest 82708182091f 3 minutes ago 2.06GBAfter changes REPOSITORY TAG IMAGE ID CREATED SIZE
vsc-miniconda-62fb3f29e4a9189b28ec2500ae0bbb7d3c31676a6ead82d187ffd0f867dab9c6 latest 504b0619dd23 3 minutes ago 1.67GB |
samruddhikhandale
previously approved these changes
Sep 11, 2023
Member
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
Looks good, left one comment!
…dockerfile_decrease_image_size
samruddhikhandale
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devcontainer name:
Description:
This PR contains the same changes as in #692. The main idea is to make the anaconda and miniconda devcontainers consistent.
Changelog:
The
pip installandconda installcommands now execute against thecontinuumio/miniconda3image. (This will allow us to not worry aboutoptfolder permissions and ownership since we can set them up duringCOPYinstruction);The
COPYinstruction now sets up permissions and ownership for theoptfolder. TheCOPYinstruction will not create an additional layer, which should help decrease image size;Previous commands for setting up permissions and ownership were removed.
Checklist: