[universal] Address GHSA-jm77-qphf-c4w8 and GHSA-r9hx-vwmv-q579 vulnerabilities #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update check for `cryptography` package; - Rename tests to make them more explicit; - Update tests to use a separate conda's environment;
samruddhikhandale
approved these changes
Sep 13, 2023
samruddhikhandale
approved these changes
Sep 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devcontainer name:
Description:
This PR patches the following vulnerabilities:
cryptographypackage;setuptoolspackage. The vulnerability was patched a while ago, but thesite-packagesfolder contained an older version of the related package, which triggers security scanners;Changelog:
patch-condafeature:cryptographypackage version to address GHSA-jm77-qphf-c4w8;patch-pythonfeature:--useroption from thepip installcommand. To make sure that thesite-packagesfolder doesn't contain older versions of patched packages.Tests:
Updated test to verify
cryptographyminimum version (Minimum package version set to41.0.3which fixes GHSA-jm77-qphf-c4w8);Updated tests to use different environments when installing packages from the
conda-forgechannel;Conda tests were renamed to make names more explicit;
Checklist: