[anaconda] Rework patch for GHSA-94vc-p8w7-5p49 #815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `setuptools` and `wheel` to avoid potential issues with installing newer versions of packages; - Bump "imagecodecs" version; - Add test for "imagecodecs" minimum version;
| RUN conda install \ | ||
| RUN conda install \ | ||
| # Update "setuptools" and "wheel" to avoid potential issues with installing newer versions of packages | ||
| setuptools=68.0.0 \ |
There was a problem hiding this comment.
Do we need to pin setuptools and wheel to this specific version for making it compatible with imagecodecs ?
If so, can we add a note that imagecodecs is dependent on them, so that we don't unpin it accidentally?
|
Unfortunately, the image build is still failing with these changes^ . See https://github.com/devcontainers/images/actions/runs/6565254242/job/17833552777#step:6:2240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devcontainer name:
Description:
The previous patch (#807) was reverted in #812 due to the following error:
ERROR: Could not build wheels for imagecodecs, which is required to install pyproject.toml-based projectsIt seems the issue could be related to old versions of
setuptoolsandwheelpackages. To address this issue, the patch was reworked to update versions ofsetuptoolsandwheelpackages along withimagecodecs.Changelog:
Updated
setuptoolsandwheelto avoid potential issues with installing newer versions of packages;Bumped
imagecodecspackage version to address GHSA-94vc-p8w7-5p49;Added test to verify
imagecodecsminimum version (Minimum package version set to2023.9.18which fixes GHSA-94vc-p8w7-5p49);Checklist: