Skip to content

[anaconda] Rework patch for GHSA-94vc-p8w7-5p49 #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[anaconda] Rework patch for GHSA-94vc-p8w7-5p49 #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf55a11
[anaconda] Rework patch for GHSA-94vc-p8w7-5p49
alexander-smolyakov Oct 18, 2023
538d548
[test] Update install command
alexander-smolyakov Oct 19, 2023
eed4ec2
Merge branch 'main' into anaconda_rework_patch_for_GHSA-94vc-p8w7-5p49
alexander-smolyakov Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/anaconda/.devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ RUN . /etc/os-release && if [ "${VERSION_CODENAME}" != "bullseye" ]; then exit 1

# Temporary: Upgrade python packages due to mentioned CVEs
# They are installed by the base image (continuumio/anaconda3) which does not have the patch.
RUN conda install \
RUN conda install \
# Update "setuptools" and "wheel" to avoid potential issues with installing newer versions of packages
setuptools=68.0.0 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pin setuptools and wheel to this specific version for making it compatible with imagecodecs ?
If so, can we add a note that imagecodecs is dependent on them, so that we don't unpin it accidentally?

wheel=0.41.2 \
# pyopenssl should be updated to be compatible with latest version of cryptography
pyopenssl=23.2.0 \
pyopenssl=23.2.0 \
# https://github.com/advisories/GHSA-jm77-qphf-c4w8
cryptography=41.0.3 \
# https://github.com/advisories/GHSA-j8r2-6x86-q33q
Expand Down Expand Up @@ -39,7 +42,9 @@ RUN python3 -m pip install --upgrade \
# https://github.com/advisories/GHSA-r726-vmfq-j9j3
jupyter_server==2.7.2 \
# https://github.com/advisories/GHSA-v845-jxx5-vc9f
urllib3==1.26.17
urllib3==1.26.17 \
# https://github.com/advisories/GHSA-94vc-p8w7-5p49
imagecodecs[all]==2023.9.18

# Reset and copy updated files with updated privs to keep image size down
FROM mcr.microsoft.com/devcontainers/base:1-bullseye
Expand Down
1 change: 1 addition & 0 deletions src/anaconda/test-project/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ checkPythonPackageVersion "mpmath" "1.3.0"
checkPythonPackageVersion "aiohttp" "3.8.5"
checkPythonPackageVersion "jupyter_server" "2.7.2"
checkPythonPackageVersion "urllib3" "1.26.17"
checkPythonPackageVersion "imagecodecs" "2023.9.18"

# The `tornado` package doesn't have the `__version__` attribute so we can use the `version` attribute.
tornado_version=$(python -c "import tornado; print(tornado.version)")
Expand Down