Skip to content

Ruby: Release 3.3 #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2024
Merged

Ruby: Release 3.3 #905

merged 2 commits into from
Jan 17, 2024

Conversation

@tiagogodinho
Copy link
Contributor

Ref: #866

@tiagogodinho
Copy link
Contributor Author

@microsoft-github-policy-service agree

@tiagogodinho please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@tiagogodinho tiagogodinho marked this pull request as ready for review January 4, 2024 12:53
@tiagogodinho tiagogodinho requested a review from a team as a code owner January 4, 2024 12:53
@eljog
Copy link
Member

eljog commented Jan 6, 2024

Thank you for your contribution. We will review it soon.
I have approved for workflow runs

@viktorianer viktorianer mentioned this pull request Jan 15, 2024
Closed
eljog
eljog reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@eljog eljog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
Added a comment on the manifest

samruddhikhandale
samruddhikhandale approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@samruddhikhandale samruddhikhandale merged commit 02165dc into devcontainers:main Jan 17, 2024
@mjankowski mjankowski mentioned this pull request Jan 17, 2024
Merged
@eljog eljog mentioned this pull request Jan 17, 2024
Merged
@tiagogodinho tiagogodinho deleted the ruby-3.3 branch January 20, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eljog eljog eljog left review comments

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiagogodinho @eljog @samruddhikhandale