New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Dutch translation #107

Merged
merged 1 commit into from Dec 17, 2017

Conversation

Projects
None yet
3 participants
@tilsammans
Contributor

tilsammans commented Aug 13, 2017

No description provided.

@GeorgeWL

GeorgeWL approved these changes Aug 15, 2017 edited

I don't know dutch, but google tells me it's right.

@tilsammans

This comment has been minimized.

Show comment
Hide comment
@tilsammans

tilsammans Aug 15, 2017

Contributor

Dutch (nl-nl) tend to leave many English terms as they are.

If you want I can provide Belgium localisation too, they usually translate more words.

Contributor

tilsammans commented Aug 15, 2017

Dutch (nl-nl) tend to leave many English terms as they are.

If you want I can provide Belgium localisation too, they usually translate more words.

@GeorgeWL

This comment has been minimized.

Show comment
Hide comment
@GeorgeWL

GeorgeWL Aug 15, 2017

Collaborator

Yeah do that too, we'd like as many languages as possible.

Collaborator

GeorgeWL commented Aug 15, 2017

Yeah do that too, we'd like as many languages as possible.

@tilsammans

This comment has been minimized.

Show comment
Hide comment
@tilsammans

tilsammans Aug 16, 2017

Contributor

@GeorgeWL trouble is, it's the same language but different locale, i.e. nl_BE.

The files are currently named after the language only. What to do?

Contributor

tilsammans commented Aug 16, 2017

@GeorgeWL trouble is, it's the same language but different locale, i.e. nl_BE.

The files are currently named after the language only. What to do?

@GeorgeWL

This comment has been minimized.

Show comment
Hide comment
@GeorgeWL

GeorgeWL Aug 16, 2017

Collaborator

hmm dunno. two options. Replace nl_nl with nl_BE or take the time to make sure it works and try using locales.

Cause tbh, we could do with a few other languages having Language-Locale codes, such as en-US and en-GB.

zh-Hans Chinese (Simplified) & zh-Hant Chinese(Traditional) will eventually need it too when we get around to finding someone that knows Chinese.

I feel like it should be possible to use the extended ISO without any changes as it just looks for strings that match at a cursory glance (but I've not taken the time to look properly yet.)

Either way, best to put it as separate issues & pull requests and then get this pulled @devcows .

Collaborator

GeorgeWL commented Aug 16, 2017

hmm dunno. two options. Replace nl_nl with nl_BE or take the time to make sure it works and try using locales.

Cause tbh, we could do with a few other languages having Language-Locale codes, such as en-US and en-GB.

zh-Hans Chinese (Simplified) & zh-Hant Chinese(Traditional) will eventually need it too when we get around to finding someone that knows Chinese.

I feel like it should be possible to use the extended ISO without any changes as it just looks for strings that match at a cursory glance (but I've not taken the time to look properly yet.)

Either way, best to put it as separate issues & pull requests and then get this pulled @devcows .

@GeorgeWL GeorgeWL closed this Sep 1, 2017

@ryanfox1985 ryanfox1985 reopened this Dec 17, 2017

@ryanfox1985 ryanfox1985 merged commit 0113621 into devcows:master Dec 17, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment