New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Https #135

Merged
merged 2 commits into from Jan 8, 2018

Conversation

Projects
None yet
2 participants
@coling
Contributor

coling commented Dec 15, 2017

Just updating some http:// URLs to https:// equivs. Seeing as everyone uses https nowadays right!

Colin Guthrie added some commits Dec 15, 2017

Colin Guthrie
Update style URLs to https.
The old URL redirects to this new URL anyway and allows us to avoid
any mixed content warnings.
Colin Guthrie
Update the static maps URL to https
Avoids any mixed content warnings

@ryanfox1985 ryanfox1985 self-requested a review Dec 15, 2017

@ryanfox1985

This comment has been minimized.

Show comment
Hide comment
@ryanfox1985

ryanfox1985 Dec 15, 2017

Member

Hi @coling !

thanks for the PR, can you use this way to let the browser to choose the protocol to use.

Regards!

Member

ryanfox1985 commented Dec 15, 2017

Hi @coling !

thanks for the PR, can you use this way to let the browser to choose the protocol to use.

Regards!

@coling

This comment has been minimized.

Show comment
Hide comment
@coling

coling Dec 15, 2017

Contributor

@ryanfox1985 That would work for the maps URL change in the second commit for now, but on the first link to the zebra pattern, it redirects to https if you request http. So in this case, it's better to be explicit with https and avoid a needless 301.

And I suspect at some point the maps URL will do the same and redirect to https in all cases, so you may as well be explicit there too.

Contributor

coling commented Dec 15, 2017

@ryanfox1985 That would work for the maps URL change in the second commit for now, but on the first link to the zebra pattern, it redirects to https if you request http. So in this case, it's better to be explicit with https and avoid a needless 301.

And I suspect at some point the maps URL will do the same and redirect to https in all cases, so you may as well be explicit there too.

@ryanfox1985 ryanfox1985 merged commit f2f2c4f into devcows:master Jan 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment