New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed favicon not updating #165

Merged
merged 3 commits into from Aug 14, 2018

Conversation

Projects
None yet
5 participants
@rogerssam
Contributor

rogerssam commented Jun 1, 2018

Missing / prevented favicon being found and updating.

Sam Rogers
Fixed favicon not updating
Missing / prevented favicon being found and updating.
@GeorgeWL

seems all good.

@modille

This comment has been minimized.

Show comment
Hide comment
@modille

modille Jun 1, 2018

Interesting... I'm guessing hugo was detecting the rel attribute and automatically making it relative?

An even better approach might be to use the relUrl and absUrl functions

https://gohugo.io/functions/relurl/

https://gohugo.io/functions/absurl/

modille commented Jun 1, 2018

Interesting... I'm guessing hugo was detecting the rel attribute and automatically making it relative?

An even better approach might be to use the relUrl and absUrl functions

https://gohugo.io/functions/relurl/

https://gohugo.io/functions/absurl/

@GeorgeWL

This comment has been minimized.

Show comment
Hide comment
@GeorgeWL

GeorgeWL Jun 1, 2018

Collaborator

@modille or @therog1 think you could make a pull using that instead?

feels more reliable to me to use the native functions.

Collaborator

GeorgeWL commented Jun 1, 2018

@modille or @therog1 think you could make a pull using that instead?

feels more reliable to me to use the native functions.

@ryanfox1985

This comment has been minimized.

Show comment
Hide comment
@ryanfox1985

ryanfox1985 Jun 1, 2018

Member

I agree with @GeorgeWL

Member

ryanfox1985 commented Jun 1, 2018

I agree with @GeorgeWL

@GeorgeWL

https://gohugo.io/functions/relurl/

https://gohugo.io/functions/absurl/

@modille or @therog1 think you could make a pull using that instead?

feels more reliable to me to use the native functions.

Sam Rogers
Updated with relURL
Changed favicon to use relURL function.
@rogerssam

This comment has been minimized.

Show comment
Hide comment
@rogerssam

rogerssam Jun 6, 2018

Contributor

I've updated using relURL now, which fixes my issue, but there are some other paths which should perhaps also be using relURL. E.g. the two lines following (56 & 57):

<link href="{{ .Site.BaseURL }}css/owl.carousel.css" rel="stylesheet">
<link href="{{ .Site.BaseURL }}css/owl.theme.css" rel="stylesheet">
Contributor

rogerssam commented Jun 6, 2018

I've updated using relURL now, which fixes my issue, but there are some other paths which should perhaps also be using relURL. E.g. the two lines following (56 & 57):

<link href="{{ .Site.BaseURL }}css/owl.carousel.css" rel="stylesheet">
<link href="{{ .Site.BaseURL }}css/owl.theme.css" rel="stylesheet">
@ryanfox1985

This comment has been minimized.

Show comment
Hide comment
@ryanfox1985

ryanfox1985 Jun 8, 2018

Member

@therog1 thanks for the PR, do you want to fix the other relative paths in this PR?

Member

ryanfox1985 commented Jun 8, 2018

@therog1 thanks for the PR, do you want to fix the other relative paths in this PR?

@rogerssam

This comment has been minimized.

Show comment
Hide comment
@rogerssam

rogerssam Jun 8, 2018

Contributor

@GeorgeWL Sure, I'll fix them up when I get a few minutes.

Contributor

rogerssam commented Jun 8, 2018

@GeorgeWL Sure, I'll fix them up when I get a few minutes.

@rogerssam

This comment has been minimized.

Show comment
Hide comment
@rogerssam

rogerssam Jul 26, 2018

Contributor

There we go guys, I think that's fixed it for that partial... Seems to work ok for me, hopefully does for everyone else too!

Contributor

rogerssam commented Jul 26, 2018

There we go guys, I think that's fixed it for that partial... Seems to work ok for me, hopefully does for everyone else too!

@ryanfox1985 ryanfox1985 merged commit ecd4366 into devcows:master Aug 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment