Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

localize 404 page; allow Markdown at more places; clickable feature icons #184

Merged
merged 17 commits into from Nov 8, 2019

Conversation

@salim-b
Copy link
Contributor

salim-b commented Sep 14, 2018

I tried to translate the strings into the different supported languages as far as I could:

  • ca, de, en, fr, it, nl are complete (thanks to DeepL 馃榿);
  • in all the other languages only the 404NavHome string is translated (took it from the navHome string), the other two strings 404Error and 404Message are still in English (waiting for someone more proficient to translate them);
  • Markdown is supported in all the three 404 strings (processed by hugo's markdownify).

What I couldn't manage to translate is the page title. But as far as I understand, this isn't supported by Hugo in any proper way yet.

Besides I've

  • added support for Markdown at various additional places (mostly (sub)titles defined in the site's config file);
  • made the feature icons clickable by specifying the link key in the respective data/features/[feature_name].yaml files;
  • replaced the Bootstrapious link in the footer with a more specific one pointing to the right template (universal) and using https;
  • made the see_more section a little more flexible by avoiding error(s) when params.see_more.link_url or params.see_more.link_text aren't defined.
  • removed the duplicated site logo on the 404 page (identical to @timn's commit)
@salim-b salim-b changed the title allow Markdown in clients (sub)title localize 404 page; allow Markdown in clients (sub)title Sep 14, 2018
@salim-b salim-b force-pushed the salim-b:4upstream branch from 8b650fb to 08376d7 Sep 14, 2018
@salim-b salim-b changed the title localize 404 page; allow Markdown in clients (sub)title localize 404 page; allow Markdown at more places Sep 14, 2018
@salim-b salim-b changed the title localize 404 page; allow Markdown at more places localize 404 page; allow Markdown at more places; clickable feature icons Sep 15, 2018
salim-b added 3 commits Sep 15, 2018
avoid Hugo error(s) when `params.see_more.link_url` or `params.see_more.link_text` aren't defined
- since in the client YAML files the respective key is names `url`, I guess
  I should stick to that.

- besides I've removed the one `#` I've specified as the URL in
  `data/features/webdesign.yaml`; originally that was intended as a "visual"
  hint that now it is easily possible to make the features clickable. but I
  guess that's not really necessary, if not even irritating.
the changes in this commit are identical with timmn's commit 33ad328
@ryanfox1985 ryanfox1985 self-requested a review Sep 17, 2018
@ryanfox1985

This comment has been minimized.

Copy link
Member

ryanfox1985 commented Sep 17, 2018

Hi @salim-b , thanks for the PR.

can you replace the ca.yml:

- id: 404Error
  translation: "Error 404: P脿gina no trobada"
 - id: 404Message
  translation: "Ho sentim - aquesta p脿gina no es pot trobar en aquest lloc"
@salim-b

This comment has been minimized.

Copy link
Contributor Author

salim-b commented Sep 17, 2018

can you replace the ca.yml:

- id: 404Error
  translation: "Error 404: P脿gina no trobada"
 - id: 404Message
  translation: "Ho sentim - aquesta p脿gina no es pot trobar en aquest lloc"

Done.

Besides I've renamed the 404GoHome string to 404NavHome to be more consistent with the existing terminology (navHome string).

@salim-b

This comment has been minimized.

Copy link
Contributor Author

salim-b commented Apr 17, 2019

@ryanfox1985 what's holding you back to merge this pull request?

@ryanfox1985

This comment has been minimized.

Copy link
Member

ryanfox1985 commented Apr 18, 2019

I want to test locally this PR.

@salim-b

This comment has been minimized.

Copy link
Contributor Author

salim-b commented Oct 26, 2019

I want to test locally this PR.

@ryanfox1985 Could you test it in the meantime?

ryanfox1985 and others added 3 commits Oct 26, 2019
@ryanfox1985 ryanfox1985 merged commit 2c95159 into devcows:master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@salim-b salim-b deleted the salim-b:4upstream branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.