New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Grabbing image #83

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
3 participants
@ryanfox1985
Member

ryanfox1985 commented Jun 9, 2017

I added the image.
This closes #80

@ryanfox1985 ryanfox1985 requested review from adrianmo and GeorgeWL Jun 9, 2017

@GeorgeWL

Isn't this being requested by jquery.min.js though, so it actually has to be in root of css rather than /img/ ?

I forget tbh...

@ryanfox1985

This comment has been minimized.

Show comment
Hide comment
@ryanfox1985

ryanfox1985 Jun 11, 2017

Member

@GeorgeWL the image is requested by the library owl carousel. We have an images folder and I think is better to not mix css and images.

Member

ryanfox1985 commented Jun 11, 2017

@GeorgeWL the image is requested by the library owl carousel. We have an images folder and I think is better to not mix css and images.

@GeorgeWL

This comment has been minimized.

Show comment
Hide comment
@GeorgeWL

GeorgeWL Jun 12, 2017

Collaborator

I totally agree with you there, only said that cause thought it was one of those silly libraries where it fucks up if not where expected and doesn't give option of moving directory unless you unminify the code and reminify.

Collaborator

GeorgeWL commented Jun 12, 2017

I totally agree with you there, only said that cause thought it was one of those silly libraries where it fucks up if not where expected and doesn't give option of moving directory unless you unminify the code and reminify.

Added Grabbing image
I added the image.
This closes #80

@ryanfox1985 ryanfox1985 dismissed stale reviews from adrianmo and GeorgeWL via b43ea96 Jun 12, 2017

@ryanfox1985 ryanfox1985 merged commit 86ab778 into master Jun 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ryanfox1985 ryanfox1985 deleted the feature/fix_image branch Jun 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment