New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esm builds #583

Merged
merged 12 commits into from Jul 9, 2018

Conversation

Projects
None yet
3 participants
@prateekbh
Collaborator

prateekbh commented Jun 1, 2018

What kind of change does this PR introduce?
Introduces babel7 and build mirrored es6 bundles for eeverything. Ships es6 with <script type=module

Did you add tests for your changes?
No, The snapshot thing is flaky with the babel-esm-plugin.

Summary

This is part 1 of 2 PRs to come which will put a new flag(--esm) in preact build. This will ship es6 and es5 code both using module/nomodule.

There will be followup PRs to compliment the functionality in SW

Does this PR introduce a breaking change?
No.

Other information
Spiderman dies in Avengers infinity war. #Sorry

@ForsakenHarmony

This comment has been minimized.

Show comment
Hide comment
@ForsakenHarmony

ForsakenHarmony Jun 1, 2018

Collaborator

very nice

do you think we need a flag? I think we could have it as default with opt out myb

Collaborator

ForsakenHarmony commented Jun 1, 2018

very nice

do you think we need a flag? I think we could have it as default with opt out myb

@prateekbh

This comment has been minimized.

Show comment
Hide comment
@prateekbh

prateekbh Jun 1, 2018

Collaborator

About the flag... This experiment is so new that there definitely should be a way to turn it off... So may be a flag with default on

Collaborator

prateekbh commented Jun 1, 2018

About the flag... This experiment is so new that there definitely should be a way to turn it off... So may be a flag with default on

@reznord

This comment has been minimized.

Show comment
Hide comment
@reznord

reznord Jun 1, 2018

Collaborator

+1 for the --esm flag on preact build command.

We can leave it off by default and we can enable it by the --esm flag (just my thoughts)

Collaborator

reznord commented Jun 1, 2018

+1 for the --esm flag on preact build command.

We can leave it off by default and we can enable it by the --esm flag (just my thoughts)

"babel-plugin-transform-react-remove-prop-types": "^0.4.5",
"babel-preset-env": "^1.3.3",

This comment has been minimized.

@reznord

reznord Jun 8, 2018

Collaborator

Isn't this required? Preact build command fails at the moment

@reznord

reznord Jun 8, 2018

Collaborator

Isn't this required? Preact build command fails at the moment

This comment has been minimized.

@ForsakenHarmony

ForsakenHarmony Jun 8, 2018

Collaborator

look up a couple of lines, has to be changed in the babel config though

@ForsakenHarmony

ForsakenHarmony Jun 8, 2018

Collaborator

look up a couple of lines, has to be changed in the babel config though

This comment has been minimized.

@prateekbh

prateekbh Jun 8, 2018

Collaborator

oh yeah...

@prateekbh

prateekbh Jun 8, 2018

Collaborator

oh yeah...

prateekbh added some commits Jun 8, 2018

@prateekbh prateekbh changed the title from [WIP] Esm builds to Esm builds Jun 16, 2018

@prateekbh

This comment has been minimized.

Show comment
Hide comment
@prateekbh

prateekbh Jun 27, 2018

Collaborator

Requesting a round of review... Tested, Works fine for me.

Collaborator

prateekbh commented Jun 27, 2018

Requesting a round of review... Tested, Works fine for me.

@ForsakenHarmony ForsakenHarmony merged commit 383d070 into next Jul 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prateekbh prateekbh deleted the esm-builds branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment