Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG compatibility; preact as peerDependency #1

Merged
merged 8 commits into from Sep 26, 2016

Conversation

@zemlanin
Copy link
Contributor

zemlanin commented Sep 25, 2016

No description provided.

zemlanin added 4 commits Sep 25, 2016
`EVENT_NAME_MAP` is a plain object so it should be fine
if project depends on `preact-css-transition-group` and `preact@6`, npm loads two preacts. because of that, children of the CSSTransitionGroup are rendered as `[object Object]`

also:
- bump min preact requirement to 5.7.0 because of failing transitionEnter (seems like it is related to #257)
- lint tests
- specify preact version with `PREACT_VERSION` env var (for example, `PREACT_VERSION=./tests/preact-versions/5.7.0.js npm test`)
- load preact version with `peer:preact` npm script (`npm run peer:preact -- 5.7.0`)
- travis test supported preact versions
SVGElement::className isn’t a `string`, it’s a `SVGAnimatedString`
@developit

This comment has been minimized.

Copy link
Owner

developit commented Sep 25, 2016

Nice, this looks good. Might want to gitignore the dist files for preact versions though?

zemlanin added 4 commits Sep 25, 2016
split PREACT_FILE and PREACT_VERSION
@developit

This comment has been minimized.

Copy link
Owner

developit commented Sep 25, 2016

@zemlanin Looks like this is all ready to go. Good to merge?

@zemlanin

This comment has been minimized.

Copy link
Contributor Author

zemlanin commented Sep 25, 2016

@developit developit merged commit 75486aa into developit:master Sep 26, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@developit

This comment has been minimized.

Copy link
Owner

developit commented Sep 26, 2016

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.