SVG compatibility; preact as peerDependency #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`EVENT_NAME_MAP` is a plain object so it should be fine
if project depends on `preact-css-transition-group` and `preact@6`, npm loads two preacts. because of that, children of the CSSTransitionGroup are rendered as `[object Object]` also: - bump min preact requirement to 5.7.0 because of failing transitionEnter (seems like it is related to #257) - lint tests - specify preact version with `PREACT_VERSION` env var (for example, `PREACT_VERSION=./tests/preact-versions/5.7.0.js npm test`) - load preact version with `peer:preact` npm script (`npm run peer:preact -- 5.7.0`) - travis test supported preact versions
SVGElement::className isn’t a `string`, it’s a `SVGAnimatedString`
|
Nice, this looks good. Might want to gitignore the dist files for preact versions though? |
split PREACT_FILE and PREACT_VERSION
|
@zemlanin Looks like this is all ready to go. Good to merge? |
|
@developit Yep |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.