Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: Declare lifecycle methods as optional #1026

Merged
merged 1 commit into from Mar 5, 2018
Merged

TS: Declare lifecycle methods as optional #1026

merged 1 commit into from Mar 5, 2018

Conversation

marvinhagemeister
Copy link
Member

Just checked against recent TypeScript versions. Optional interface methods are correctly inferred from extended classes. Fixes #620.

@coveralls
Copy link

coveralls commented Mar 4, 2018 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 48e03cc on marvinhagemeister:ts_optional_lifecycle into c9d4efa on developit:master.

ForsakenHarmony
ForsakenHarmony approved these changes Mar 5, 2018
View reviewed changes
Copy link
Member

@ForsakenHarmony ForsakenHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 8306024 into preactjs:master Mar 5, 2018
@marvinhagemeister marvinhagemeister deleted the ts_optional_lifecycle branch March 5, 2018 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marvinhagemeister @coveralls @ForsakenHarmony