Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ceviche repo 馃帀 #1302

Merged
merged 981 commits into from Mar 4, 2019

Conversation

@marvinhagemeister
Copy link
Collaborator

marvinhagemeister commented Mar 2, 2019

This PR merges the code from ceviche back into the public repo. ceviche is our codename for Preact X. An alpha release on npm will follow shortly on March 4th.

Todos:

  • Resolve Merge-Conflicts
  • Preserve git history of both projects
  • Verify changes with git diff ceviche..ceviche/master
  • Remove 8.x code that's been unaffected by the merge
  • Verify TS types, children type-checking seems to be broken.
  • Fix missing Text-Nodes in Children tests.
  • Fix missing code coverage in compat.

Note: The commit view here on GitHub doesn't show all commits. The most recent ones are missing for me in the web ui. They're all there when viewed locally via git.

marvinhagemeister and others added some commits Jan 31, 2019

Merge pull request #205 from developit/create-context-type
Add support for `class.contextType`
Simplify _lastDomChild tracking (+0 B)
Only track lastDomChild for Fragment-like VNodes (i.e. Fragments and Components that return Fragments)

Remove _wrapsFragment experiment
Combine hydrate and render to both call diffChildren (-27 B)
Temporarily disable the devtools tests as I broke them badly :/
Merge remote-tracking branch 'origin/create-context' into create-cont鈥
鈥xt-nested

# Conflicts:
#	src/diff/index.js
Merge pull request #204 from developit/create-context-nested
Add support for nested createContext providers
Merge #208: Adapt devtools to root Fragment node
From developit/diff-children-devtools
@andrewiggins
Copy link
Collaborator

andrewiggins left a comment

馃帀

@thysultan

This comment has been minimized.

Copy link

thysultan commented Mar 3, 2019

Minor change 1 is going to prove hot on the wheels of browsers, at least in comparison to the current implementation, and when hooks land; considering inline-functions will become more common in that space. Is there any reason the previous route was ditched 鈥 1 listener mount + a map of callbacks that are updated?

@marvinhagemeister

This comment has been minimized.

Copy link
Collaborator Author

marvinhagemeister commented Mar 4, 2019

@thysultan The changelog isn't really up to date. Event listeners in ceviche work the same way as they do in current preact. That section was written before we implemented them there.

To avoid any further confusion I've removed the CHANGELOG.md.

@hassanbazzi hassanbazzi self-requested a review Mar 4, 2019

@hassanbazzi

This comment has been minimized.

Copy link
Collaborator

hassanbazzi commented Mar 4, 2019

So exciting!

@dyaa

This comment has been minimized.

Copy link

dyaa commented Mar 4, 2019

Merge time, and let the community celebrate? :shipit: 馃懐 馃帀

@mochiya98

This comment has been minimized.

Copy link
Contributor

mochiya98 commented Mar 4, 2019

Why is not included "compat/*" in package.files?

@marvinhagemeister

This comment has been minimized.

Copy link
Collaborator Author

marvinhagemeister commented Mar 4, 2019

@mochiya98 Good catch! Just pushed a commit that adds compat to the files section. Thanks again for spotting this 馃憤

@developit developit merged commit 0c104d9 into master Mar 4, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (developit) No new issues
Details
@developit

This comment has been minimized.

Copy link
Owner

developit commented Mar 4, 2019

aaaaand we're a go

@dyaa

This comment has been minimized.

Copy link

dyaa commented Mar 4, 2019

@developit dont forget the npm release 馃槈

@flppv

This comment has been minimized.

Copy link

flppv commented Mar 4, 2019

Great job! Waiting for updated docs and release notes 馃槉

@webdeb

This comment has been minimized.

Copy link

webdeb commented Mar 5, 2019

@marvinhagemeister 馃帀

@marvinhagemeister marvinhagemeister referenced this pull request Mar 5, 2019

Closed

add dev server #851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.