Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per #813, convert svg names of strokeWidth to stroke-width #956

Closed
wants to merge 2 commits into from

Conversation

NateRadebaugh
Copy link

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9b37e76 on NateRadebaugh:master into 17cc8de on developit:master.

@developit
Copy link
Member

developit commented Dec 15, 2017

Can probably have this be generic. .replace(/([A-Z])/g, '$1-')

@NateRadebaugh
Copy link
Author

Also, it looks like there isn't really any consistency in the formatting of element/attributes; some have hyphens and some are camelCase. That regex is going to append - to every svg name, which would break more than it would fix wouldn't it..?

https://developer.mozilla.org/en-US/docs/Web/SVG/Element
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d9f9b94 on NateRadebaugh:master into b5df49e on developit:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants