use flex instead of recalculating input width #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make input width grow to cover all the space not used already by tags
developit
reviewed
Nov 24, 2016
| @@ -1,5 +1,6 @@ | |||
| .tags-input { | |||
| display: inline-block; | |||
| display: inline-flex; | |||
| flex-wrap: wrap; | |||
There was a problem hiding this comment.
seems like this would need a min-width if it were to match the current implementation, right?
There was a problem hiding this comment.
I actually thought we would need min-width on the .tags-input input - it would make input render on new line if there isn't enough space for it. But I wasn't sure I can come up with a reasonable defaults (percentage, absolute value?). I'll gladly to add whatever defaults you seem appropriate.
There was a problem hiding this comment.
I would say min-width should be 25% since the old calculation was Math.max(..., w / 4).
And maybe also add a min-width on the whole .tags-input.
Btw thank you guys, this component is awesome 😄 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.