Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure tags that mismatch pattern are not added #23

Open
wants to merge 3 commits into
base: master
from

Conversation

@thomasdegry
Copy link

thomasdegry commented May 19, 2017

Fixes #20 and #21 to ensure that tags that don't get added if they mismatch with the pattern attribute.

This is just what @mikemaccana had but does not rely on include to ensure IE support. Got rid of the tilde trick and just check if indexOf is equal or greater than 0.

Also added some styles to flash the input box to indicate that the content is invalid.

Copy link
Owner

developit left a comment

Looks good!

@thomasdegry

This comment has been minimized.

Copy link
Author

thomasdegry commented May 21, 2017

Awesome; anything else that needs to happen before we merge?

return false;
}

// Don't add if iti's invalid (eg, for pattern=)

This comment has been minimized.

Copy link
@zaygraveyard

zaygraveyard May 21, 2017

Found a typo, "iti's" should be "it's"

@developit

This comment has been minimized.

Copy link
Owner

developit commented May 21, 2017

I think we're good, just didn't want to do it on a plane haha

@thomasdegry

This comment has been minimized.

Copy link
Author

thomasdegry commented May 22, 2017

Awesome! Understandable 😄
I fixed the typo that @zaygraveyard pointed out as well, thank you for that! 👍

@tumpio

This comment has been minimized.

Copy link

tumpio commented Jun 2, 2017

Can we make a release for this?

@tumpio

This comment has been minimized.

Copy link

tumpio commented Jun 2, 2017

hmm there seems to be quite big fork in https://github.com/pirxpilot/tags-input

@tumpio tumpio mentioned this pull request Jun 3, 2017
@VSG24

This comment has been minimized.

Copy link

VSG24 commented Jun 27, 2017

@developit WTH... just do it already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.