-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Add pubsub notifications #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d7cdec5 to
fc728e1
Compare
68843e0 to
f32f782
Compare
mneagul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the changes recommended by me. The need for a KSVC is not clear.
94461cf to
909c88a
Compare
e050729 to
30acab3
Compare
|
Thanks for your input @mneagul. I adjusted as you suggested. This PR overall has advanced an is in a shape to be reviewed (again). |
30acab3 to
5504bec
Compare
5504bec to
f376b28
Compare
ciaransweet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be using pytest.skip when conditions aren't met? I think we'd want to instead fail tests no?
|
Thanks for your review, @ciaransweet! I adjusted the code according to your comments. |
88c8c43 to
d16f88f
Compare
Related to: EOEPCA/resource-discovery#167