Skip to content

Conversation

@pantierra
Copy link
Contributor

@pantierra pantierra commented Sep 11, 2025

Related to: EOEPCA/resource-discovery#167

  • This PR adds PostgreSQL notification triggers to the pgstac database that automatically send real-time notifications when STAC items are inserted, updated, or deleted. This enables event-driven applications to respond to catalog changes.
  • It includes eoapi-notifier middle-ware to listen on these notifications and redirect notification messages as cloudevents to knative (alternatively mqtt can also be used)

@pantierra pantierra marked this pull request as draft September 11, 2025 08:17
@pantierra pantierra force-pushed the feature/add-listen-notify branch 4 times, most recently from d7cdec5 to fc728e1 Compare September 11, 2025 09:54
@pantierra pantierra changed the title Add notification triggers in database. feat: Add notification triggers in database. Sep 11, 2025
@pantierra pantierra force-pushed the feature/add-listen-notify branch 8 times, most recently from 68843e0 to f32f782 Compare September 15, 2025 12:56
@pantierra pantierra changed the title feat: Add notification triggers in database. feat: Add pubsub notifications Sep 15, 2025
Copy link

@mneagul mneagul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the changes recommended by me. The need for a KSVC is not clear.

@pantierra pantierra force-pushed the feature/add-listen-notify branch 5 times, most recently from 94461cf to 909c88a Compare September 18, 2025 19:10
@pantierra pantierra marked this pull request as ready for review September 19, 2025 08:24
@pantierra pantierra force-pushed the feature/add-listen-notify branch from e050729 to 30acab3 Compare September 19, 2025 08:25
@pantierra
Copy link
Contributor Author

Thanks for your input @mneagul. I adjusted as you suggested. This PR overall has advanced an is in a shape to be reviewed (again).

@pantierra pantierra force-pushed the feature/add-listen-notify branch from 30acab3 to 5504bec Compare September 22, 2025 11:53
@pantierra pantierra force-pushed the feature/add-listen-notify branch from 5504bec to f376b28 Compare September 22, 2025 12:15
Copy link
Contributor

@ciaransweet ciaransweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using pytest.skip when conditions aren't met? I think we'd want to instead fail tests no?

@pantierra
Copy link
Contributor Author

Thanks for your review, @ciaransweet! I adjusted the code according to your comments.

@pantierra pantierra force-pushed the feature/add-listen-notify branch from 88c8c43 to d16f88f Compare September 23, 2025 11:19
@pantierra pantierra merged commit e9fbd0a into main Sep 23, 2025
4 checks passed
@pantierra pantierra deleted the feature/add-listen-notify branch September 23, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants