fix: Helper for postgrescluster.enabled false when using external db #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
hotfix/db-config-disable-postgrescluster
branch
from
de7f047 to
84292ed
Compare
pantierra
force-pushed
the
hotfix/db-config-disable-postgrescluster
branch
7 times, most recently
from
083c15f to
0db8ebe
Compare
pantierra
force-pushed
the
hotfix/db-config-disable-postgrescluster
branch
from
0db8ebe to
dfb1800
Compare
batpad
approved these changes
Nov 14, 2025
Member
batpad
left a comment
batpad
left a comment
There was a problem hiding this comment.
this looks really good to me, thanks @pantierra !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #224
Issue is to prevent PostgresCluster resources from being created when using external databases:
postgrescluster.enabled: falsewhenpostgresql.typeis set toexternal-plaintextorexternal-secret,postgresclustertemplates to properly respect the enabled flag