feat: Add clarification about concurrency and db connection configuration. #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
feature/concurrency-autosclaing
branch
from
d062b41 to
0833cb5
Compare
ciaransweet
reviewed
Nov 18, 2025
charts/eoapi/values.yaml
Outdated
Comment on lines
390
to
396
| # Multidim service (similar to raster - CPU intensive operations) | ||
| WEB_CONCURRENCY: "4" | ||
| ############## | ||
| # Database Pool | ||
| ############## | ||
| DB_MIN_CONN_SIZE: "1" | ||
| DB_MAX_CONN_SIZE: "3" |
Contributor
There was a problem hiding this comment.
Worth just maintaining the same comment structure? We've got it duplicated everywhere else?
Contributor
Author
There was a problem hiding this comment.
Yeah, maybe too much. Reduced it.
pantierra
force-pushed
the
feature/concurrency-autosclaing
branch
from
0833cb5 to
386abd2
Compare
pantierra
force-pushed
the
feature/concurrency-autosclaing
branch
from
386abd2 to
4f1c2d6
Compare
Contributor
Author
|
@vincentsarago would you agree with the defaults being set here? |
ciaransweet
approved these changes
Nov 19, 2025
Contributor
ciaransweet
left a comment
ciaransweet
left a comment
There was a problem hiding this comment.
LGTM, guess you still want @vincentsarago 's input!
vincentsarago
approved these changes
Nov 20, 2025
Contributor
Author
|
Thanks both for your reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #201