Skip to content

Allow custom annotations #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

Allow custom annotations #66

merged 1 commit into from
Jan 18, 2024

Conversation

@ghelobytes
Copy link
Contributor

@ghelobytes ghelobytes commented Jan 11, 2024

Allow custom annotations to be added via values.yaml. For example, when using oauth2-proxy to hide API behind auth.

ingress:
  annotations:
    nginx.ingress.kubernetes.io/auth-url: "https://$host/oauth2/auth"
    nginx.ingress.kubernetes.io/auth-signin: "https://$host/oauth2/start?rd=$escaped_request_uri"
    nginx.ingress.kubernetes.io/enable-cors: "true"

ranchodeluxe
ranchodeluxe approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@ranchodeluxe ranchodeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you help @ghelobytes 🥳

This makes sense to support

@ranchodeluxe ranchodeluxe merged commit b9eb547 into developmentseed:main Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ranchodeluxe ranchodeluxe ranchodeluxe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ghelobytes @ranchodeluxe