-
Notifications
You must be signed in to change notification settings - Fork 3
feat(helm): Add support for initContainers. #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alukach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be honest that this is a bit beyond my knowledge but it appears reasonable
|
I should also note that today, the STAC Auth Proxy does do a wait for the upstream STAC API to be available before accepting requests: stac-auth-proxy/src/stac_auth_proxy/lifespan.py Lines 31 to 63 in 5ce9487
|
|
At least in Kubernetes, |
|
Seems like this just adds support to allow someone deploying this to add a custom init container? Seems good to me, if being able to configure that is useful, makes sense 👍 |
|
Hmm am seeing CI failures that seem unrelated to this commit. Not sure what's going on there. |
|
Thanks for your reviews! Yes, the errors seemed unrelated to me, too. Can this be merged? |
|
@pantierra good to go now |
This could be useful when the auth server is deployed with stac-auth-proxy and we need to wait.
At least in eoAPI would be good for testing (developmentseed/eoapi-k8s#358).