Skip to content

fix: add page input validation #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix: add page input validation #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion adminforth/spa/src/components/ResourceListTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
<div
contenteditable="true"
class="min-w-10 outline-none inline-block w-auto min-w-10 py-1.5 px-3 text-sm text-center text-gray-700 border border-gray-300 dark:border-gray-700 dark:text-gray-400 dark:bg-gray-800 z-10"
@keydown="onPageKeydown($event)"
@input="page = parseInt($event.target.innerText) || ''"
>
{{ pageInput }}
Expand Down Expand Up @@ -271,7 +272,7 @@
<script setup lang="ts">


import { computed, onMounted, ref, watch, useTemplateRef, type Ref } from 'vue';
import { computed, onMounted, ref, watch, useTemplateRef, nextTick, type Ref } from 'vue';
import { callAdminForthApi } from '@/utils';
import { useI18n } from 'vue-i18n';
import ValueRenderer from '@/components/ValueRenderer.vue';
Expand Down Expand Up @@ -329,6 +330,14 @@ const to = computed(() => Math.min((page.value || 1) * props.pageSize, props.tot
watch(() => page.value, (newPage) => {
emits('update:page', newPage);
});
async function onPageKeydown(event) {
// page input should accept only numbers, arrow keys and backspace
if (['Enter', 'Space'].includes(event.code) ||
(!['Backspace', 'ArrowRight', 'ArrowLeft'].includes(event.code)
&& isNaN(String.fromCharCode(event.keyCode)))) {
event.preventDefault();
}
}

watch(() => sort.value, (newSort) => {
emits('update:sort', newSort);
Expand Down