Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code for further fixing #113

Merged
merged 2 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@szepeviktor
Copy link
Contributor

commented Apr 14, 2019

@Nomafin this-terminate(); was critical, others help proceeding with fixing errors.

maybe_cache() contained a faulty logic for checking $this->hash

$user is undefined

@Nomafin Nomafin merged commit d854748 into devgeniem:master Apr 17, 2019

@szepeviktor szepeviktor deleted the szepeviktor:phpstan-level1 branch Apr 17, 2019

@szepeviktor

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

@Nomafin If you wish me to continue please implement #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.