suport svn or git ScmSetting. #9

Open
wants to merge 12 commits into
from

Conversation

Projects
None yet
2 participants

suport svn or git ScmSetting :)

dlhartveld was assigned Jan 22, 2014

Contributor

dlhartveld commented Jan 22, 2014

We are certainly willing to merge in svn scm support.

Right now, your commits contain a lot of whitespace noise. Could you follow the code formatting style that we are already using (as set in codeformat.xls, Eclipse formatting settings)?

Also, you removed AutoCloseable implementation to support JDK6. We would strongly prefer to just support only JDK7. Please move this to either another pull request, with rationale, or leave it out.

Finally, please leave the version number as-is; we'll release a new version once we've merged this PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment