Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonschema 4.18 migration #109

Open
ichernev opened this issue Aug 2, 2023 · 2 comments
Open

jsonschema 4.18 migration #109

ichernev opened this issue Aug 2, 2023 · 2 comments

Comments

@ichernev
Copy link

ichernev commented Aug 2, 2023

So jsonschema 4.18 is changing the way referencing works: https://github.com/python-jsonschema/jsonschema/blob/main/CHANGELOG.rst#v4180

Already dt-schema requires <4.18 to work: 188cca9

I made this issue to track the progress of getting this to work. I don't really understand what the problem is, but there are 2 general paths:

  • (short term) fix jsonschema, because it should have been backwards compatible as per release notes.
  • (long term) get dt-schema to use the new referencing library

I might be able to help with either of those, but some help in terms of what's the hack dt-schema requires that is now off limits would be nice.

P.S: I'm maintainer of alpine's py3-dt-schema package, so I spend a few hours banging my head to figure out it was jsonschema's fault all along.

@robherring
Copy link
Member

See #108

@ichernev
Copy link
Author

ichernev commented Aug 2, 2023

See #108

Do you have a branch with the referencing library being used? I could use that for alpine packaging, it is edge after all, and you can get some bug reports :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants