Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $2134-$2136 to debugger Properties Viewer #103

Merged
merged 3 commits into from Jan 18, 2017
Merged

Add $2134-$2136 to debugger Properties Viewer #103

merged 3 commits into from Jan 18, 2017

Conversation

@koitsu
Copy link
Contributor

@koitsu koitsu commented Jan 15, 2017

WARNING: This has not been tested in any way/shape/form (may not even compile cleanly).

Reference: http://forums.nesdev.com/viewtopic.php?p=186767#p186767

@devinacker
Copy link
Owner

@devinacker devinacker commented Jan 16, 2017

A couple of things: I'd prefer to keep the entire value as one line item, similarly to $2181-$2183, etc. Also, the way it's implemented right now will show the last values read by the CPU, not necessarily the actual current values.

If any extra variables are going to be added to store the multiplication result, it should be updated when the products are written, rather than when the results are read. But I think I'd prefer to just do the multiplication on-the-fly when displaying the value in the properties window, since it's never updated frequently enough to be a performance concern, and it wouldn't have to break existing savestates by adding more stuff to the serializer.

Loading

@koitsu
Copy link
Contributor Author

@koitsu koitsu commented Jan 16, 2017

Understood. I'll try to rework most of this. I'm not sure how to go about accomplishing the latter part ("only do the multiplication on-the-fly when displaying the value in the properties window").

Loading

@devinacker
Copy link
Owner

@devinacker devinacker commented Jan 16, 2017

Something like this would be fine (maybe a bit heavy on the parens though):

item("Multiplication Result", string("0x", hex<6>(((int16)regs.m7a * (int8)(regs.m7b >> 8)))));

Loading

@devinacker devinacker merged commit adcf082 into devinacker:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants