Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BG screen sizes in Properties #76

Merged
merged 1 commit into from Nov 10, 2016
Merged

Fix BG screen sizes in Properties #76

merged 1 commit into from Nov 10, 2016

Conversation

@koitsu
Copy link
Contributor

@koitsu koitsu commented Nov 10, 2016

Currently 32x64 is depicted as 64x32, and vice versa. Per offical documentation -- $2107-210a, bits 1-0, define screen size/layout:

%00 (0) = 32x32 (one screen)
%01 (1) = 64x32 (2 screens "wide", a.k.a. vertical mirroring)
%10 (2) = 32x64 (2 screens "tall", a.k.a. horizontal mirroring)
%11 (3) = 64x64 (4 screens (2 wide, 2 tall))

While I'm here: modify ppu-compatibility/debugger/debugger.cpp to also mask off all bits other than 1-0.
@koitsu
Fix BG screen sizes in Properties
8e282cf 
Currently 32x64 is depicted as 64x32, and vice versa.  Per offical
documentation -- $2107-210a, bits 1-0, define screen size/layout:

%00 = 32x32 (one screen)
%01 = 64x32 (2 screens "wide", a.k.a. vertical mirroring)
%10 = 32x64 (2 screens "tall", a.k.a. horizontal mirroring)
%11 = 64x64 (4 screens (2 wide, 2 tall))

While I'm here: modify ppu-compatibility/debugger/debugger.cpp to
also mask off all bits other than 1-0.
@devinacker devinacker merged commit 4352a3d into devinacker:master Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@koitsu @devinacker