Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Using sane defaults #200
I'm bringing this to the attention of the WordPress.org theme review team, so I wanted to give you a heads up and get everyone on the same page. I'm not overly familiar with the Options Framework, so if I get anything incorrect, please let me know.
Many theme authors use the Options Framework for their theme options on WordPress.org. As of WP version 3.9, we've had a requirement that themes must use sane defaults. This means that they cannot write any options to the database by default. The only way a theme should write options to the database is by the user explicitly saving the options. Otherwise, a default should be used.
Since the Options Framework uses
The particular code in question is the
I'm not sure if there are other areas in the framework that write to the database by default. This is just the one thing I noticed. I'll be more than happy to work with you to get things resolved.
I believe it does set an option to identify the correct option name for the theme and also to delete data if the plugin is removed. Perhaps the value can just be returned rather than set as an option. Let me do some testing on it. Thanks for opening the ticket and bringing it to my attention.