New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of suggestions to improve extensibility of Options Framework #29

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@julien-c

julien-c commented Mar 27, 2012

Documented here: http://julien-c.fr/2012/03/extending-options-framework/

Feel free to cherry pick what you merge.

Thanks!

@devinsays

This comment has been minimized.

Show comment
Hide comment
@devinsays

devinsays Mar 28, 2012

Instead of a constant it might be better to filter this. Will look into it...

devinsays commented on 7c5aae5 Mar 28, 2012

Instead of a constant it might be better to filter this. Will look into it...

This comment has been minimized.

Show comment
Hide comment
@devinsays

devinsays Dec 2, 2012

Opened this as it's own issue:
devinsays#77

It won't get in this next release, but I'll keep it open.

Thanks.

devinsays replied Dec 2, 2012

Opened this as it's own issue:
devinsays#77

It won't get in this next release, but I'll keep it open.

Thanks.

@devinsays

This comment has been minimized.

Show comment
Hide comment
@devinsays

devinsays Dec 2, 2012

Thanks. Will update.

devinsays commented on a2aea21 Dec 2, 2012

Thanks. Will update.

@devinsays

This comment has been minimized.

Show comment
Hide comment
@devinsays

devinsays Dec 2, 2012

If it's not a valid selector, it just defaults to the first tab. So I don't think this is necessarily a problem.

devinsays commented on 31a230f Dec 2, 2012

If it's not a valid selector, it just defaults to the first tab. So I don't think this is necessarily a problem.

@devinsays

This comment has been minimized.

Show comment
Hide comment
@devinsays

devinsays Dec 2, 2012

You'd need to hook in your own js anyways in order to do something when the trigger fires, so why not just set the trigger there or do a standard $('#my-tab').on('click, do_something() );

devinsays commented on f2df58a Dec 2, 2012

You'd need to hook in your own js anyways in order to do something when the trigger fires, so why not just set the trigger there or do a standard $('#my-tab').on('click, do_something() );

@devinsays

This comment has been minimized.

Show comment
Hide comment
@devinsays

devinsays Dec 2, 2012

Owner

Hi Julien. Just going through some of these pull requests since I have a release coming up. I am going to close this pull request, but I re-opened the hardcoded references as its own issue: #77

Feel free to comment on any of the items I've mentioned.

Thanks again!

Owner

devinsays commented Dec 2, 2012

Hi Julien. Just going through some of these pull requests since I have a release coming up. I am going to close this pull request, but I re-opened the hardcoded references as its own issue: #77

Feel free to comment on any of the items I've mentioned.

Thanks again!

@devinsays devinsays closed this Dec 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment