Fully translation support #34

Merged
merged 1 commit into from Apr 29, 2012

Projects

None yet

2 participants

@satrya
Contributor
satrya commented Apr 22, 2012
  1. Updated the translation support
  2. In functions.php, recommended to use get_template_directory_uri() rather than get_bloginfo('template_directory')
@devinsays
Owner

Thanks. I finally got the plugin version translation ready, so it'll be good to get this one too.

It would probably be better if the textdomain could be a variable so a developer could quickly change it, but I feel like there are some security issues with that. I'm going to read up on it a little more. Do you know anything about doing that?

@devinsays
Owner

Nope, can't use variables: http://markjaquith.wordpress.com/2011/10/06/translating-wordpress-plugins-and-themes-dont-get-clever/

However, since optionsframework is everywhere, might be better to use a string like "optionsframeworktheme" or "optionstextdomain". I merge and update when I have a minute.

@satrya
Contributor
satrya commented Apr 24, 2012

Wow, I don't know about using variable for translation is a bad idea..

@devinsays devinsays merged commit f8eda75 into devinsays:master Apr 29, 2012
@devinsays
Owner

Cool. This was just updated. Thanks for all your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment