Permalink
Commits on Aug 8, 2012
  1. Fix bugs added by using the ETS table found by quickcheck

    Additionally, fix some minor issues in the quickcheck test
    Vagabond committed Aug 8, 2012
Commits on Aug 7, 2012
  1. Merge pull request #11 from jamesgolick/master

    poolboy:status/1
    committed Aug 7, 2012
Commits on Jul 4, 2012
Commits on Apr 27, 2012
  1. Several additions and improvements

    - Change a `queue:len/1` call during a checkout in the ready state to use
      `queue:is_empty/1`. All operations in poolboy that aren't informational
      or disaster recovery should now theoretically be O(1).
    - There is now "transaction" support using `transaction/2`. This will
      run a user defined function passed the worker checked out in a try
      block, ensuring that the worker is checked back into the pool should
      the operation fail.
    - A `child_spec/2` helper for embedding poolboy pools  within your
      supervisors.
    - Documentation updates.
    committed Apr 27, 2012
  2. Use the supervisor the shutdown a worker when it's owner process dies…

    …, allowing it to terminate
    committed Apr 27, 2012
  3. Bump the version

    committed Apr 27, 2012
  4. Performance improvements and simplifications

    - Monitors are now stored in an ETS table. Simple profiling revealed
      that a lot of time was being taken in `lists:keytake/3` looking up the
      refs by pid. This should provide O(1) constant time lookup.
    - Workers are now no longer required to handle `stop` messages. Workers
      are terminated using `supervisor:terminate_child/2` and the shutdown
      strategy is no longer brutal_kill.
    - Other various cleanups.
    committed Apr 27, 2012
Commits on Apr 2, 2012
Commits on Mar 22, 2012
  1. Bump the version

    committed Mar 22, 2012
  2. Add poolboy_worker behaviour

    committed Mar 22, 2012
  3. Upgrade rebar

    committed Mar 22, 2012
  4. Convert some tabs to spaces

    committed Mar 22, 2012
Commits on Jan 31, 2012
  1. Upgrade rebar

    Devin Torres committed Jan 31, 2012
  2. Add more targets to .PHONY in Makefile and add get-deps for when we a…

    …dd PropEr
    Devin Torres committed Jan 31, 2012
  3. Sorry Kurt

    Devin Torres committed Jan 31, 2012
  4. Merge pull request #8 from basho/adt-more-quickcheck-fixes

    Fix bug with incorrect pid in monitor list
    committed Jan 31, 2012
  5. Fix issue where the wrong pid was being stored in the list of monitors

    When a pid exited while the pool was full and there were blocking
    checkouts, poolboy would put the pid of the process requesting a worker
    in the monitor tuple along with the monitor ref, instead of the pid of
    the worker.
    Vagabond committed Jan 31, 2012
Commits on Jan 27, 2012
  1. Simple cleanup & bump the version to 0.6

    Devin Torres committed Jan 27, 2012
Commits on Jan 26, 2012
  1. Merge pull request #7 from basho/adt-quickcheck

    QuickCheck Poolboy
    Devin Torres committed Jan 26, 2012
Commits on Jan 22, 2012
  1. Add a parallel property for poolboy

    To trigger some of the more interesting code, we need to truly do things
    in parallel, so blocking checkouts can actually happen while other
    requests are being made. This commit adds a parallel property for
    poolboy, based on the original serial one.
    
    One hack that was needed was to add a trailing call to erlang:self() to
    the end of each parallel branch so that we could filter out workers
    checked out by that particular branch from the model. This is necessary
    because poolboy monitors the process holding the worker and will destroy
    any workers held by a process and re-start them, if necessary, to
    maintain the right number of workers in the pool. This filtering is done
    in the next_state command, and all elements in the checked_out list in
    the model are tuples of {Worker, self()} so the list can be filtered.
    
    Happily, although this exercises more core, no additional bugs were
    found.
    Vagabond committed Jan 22, 2012
  2. Checkin non-worker processes 10% of the time and fix resulting bugs

    Checking in an invalid process corrupts the internal state similarly to
    receiving EXITs from non-worker pids.
    Vagabond committed Jan 22, 2012
  3. Add command to send poolboy EXIT messages for unrelated pids; fix bugs

    Sending poolboy EXIT messages for pids that are not workers causes
    invalid changes to poolboy's state. Also, legitimate processes dying
    after being checked back in also would corrupt the internal state. Add
    better checking in the EXIT handling code to guard against this.
    Vagabond committed Jan 22, 2012
  4. Add command to kill workers after they're checked back in, and fix bugs

    Extend the 'status' to check the number of monitors poolboy has on
    processes that have checked out workers. When a process dies after being
    checked back in, poolboy zeroes out the list of monitors for some reason.
    Vagabond committed Jan 22, 2012
  5. Add kill_worker and fix resulting bugs

    kill_worker exposed some new faults in poolboy, where the maximum size
    of the pool could end up smaller than it should be after a worker was
    killed.
    
    To help in debugging this, a 'status' command was added to poolboy to
    look at its internal state and a dynamic_precondition function was used
    to compare the expected state to the actual state.
    
    Numerous problems were discovered by doing this, poolboy had issues
    around when it changed states, like allocating the last non-overflow
    worker would leave the pool in 'ready' until the next request came in,
    instead of immediately changing the state.
    Vagabond committed Jan 22, 2012
Commits on Jan 21, 2012
  1. Add blocking checkout to quickcheck test and fix poolboy bug

    The bug discovered was that blocking checkouts that had expired were not
    being removed from the list of 'waiting' checkouts, so when a checkout
    had timed out and a worker was subsequently checked in, the new worker
    would be sent to the expired checkout request, not any current ones.
    Vagabond committed Jan 21, 2012
  2. Initial quickcheck test for poolboy

    For now, only test the simplest API; start, stop, checkout nonblocking
    and checkin.
    Vagabond committed Jan 21, 2012
Commits on Jan 5, 2012
Commits on Dec 29, 2011
Commits on Dec 27, 2011
  1. Fix typespec for checkout

    Devin Torres committed Dec 27, 2011
Commits on Nov 29, 2011
  1. Meh, that didn't work

    Devin Torres committed Nov 29, 2011