Dialyzer behaviour/callback optimizations for newer Erlang releases #38

Merged
merged 2 commits into from Jan 14, 2014

Conversation

Projects
None yet
2 participants
@drobakowski
Contributor

drobakowski commented Jan 9, 2014

To get rid of dialyzer errors like "Callback info about the poolboy_worker behaviour is not available" the new module attribute "-callback" (introduced with the Erlang release R15) should be used for behaviors instead of "behaviour_info/1". This pull request does not break any code compiled with Erlang releases prior to R15.

@devinus

This comment has been minimized.

Show comment
Hide comment
@devinus

devinus Jan 13, 2014

Owner

@drobakowski I like going to the new -callback behaviour, but Poolboy will be dropping support for pre-R15 releases like riak_core, so I think we can just safely go to -callback now.

Owner

devinus commented Jan 13, 2014

@drobakowski I like going to the new -callback behaviour, but Poolboy will be dropping support for pre-R15 releases like riak_core, so I think we can just safely go to -callback now.

@drobakowski

This comment has been minimized.

Show comment
Hide comment
@drobakowski

drobakowski Jan 14, 2014

Contributor

@devinus sounds good to me, i'll prepare an additional commit with -callback only and push it back to synlay:feature/behaviour_callback_refactoring and this pull request.

Contributor

drobakowski commented Jan 14, 2014

@devinus sounds good to me, i'll prepare an additional commit with -callback only and push it back to synlay:feature/behaviour_callback_refactoring and this pull request.

Replaced behaviour_info/1 with new -callback specs
WARNING: this commit breaks compatibility with
         Erlang releases prior to R15

devinus pushed a commit that referenced this pull request Jan 14, 2014

Devin Torres
Merge pull request #38 from synlay/feature/behaviour_callback_refacto…
…ring

Dialyzer behaviour/callback optimizations for newer Erlang releases

@devinus devinus merged commit d47df5d into devinus:master Jan 14, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment