New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill orphaned workers and prune monitor state space. #4

Merged
merged 3 commits into from Sep 30, 2011

Conversation

Projects
None yet
2 participants
@skeltoac
Contributor

skeltoac commented Sep 26, 2011

If a process checks out a worker and then dies, the DOWN message dismisses the worker without regard for the pool state. This can leave a pool with too few workers. There are also places where monitors are not removed from state. This branch fixes both problems, adds a new test, and adds monitor state checking to other tests.

@skeltoac

This comment has been minimized.

Show comment
Hide comment
@skeltoac

skeltoac Sep 26, 2011

Contributor

Sorry for the mess... I'm still green at git.

Contributor

skeltoac commented Sep 26, 2011

Sorry for the mess... I'm still green at git.

Fix demonitored pids being left in state space and check monitor list…
… length in all tests. Add user_death test to check that an orphaned worker is killed when a monitored user is reported 'DOWN'.
@devinus

This comment has been minimized.

Show comment
Hide comment
@devinus

devinus Sep 30, 2011

Owner

Looking into this as well...

Owner

devinus commented Sep 30, 2011

Looking into this as well...

@devinus devinus merged commit d27c012 into devinus:master Sep 30, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment