Improve test coverage for password expirable (#254)

* Add test cases for password expired controller

* Add .byebug_history to .gitignore

* Remove unneeded call that was for < Rails 4.0 support

.gitignore

@@ -48,3 +48,5 @@ bin/*
 gemfiles/*.lock
 
 vendor/
+
+.byebug_history

app/controllers/devise/password_expired_controller.rb

@@ -41,11 +41,7 @@ def skip_password_change
   def resource_params
     permitted_params = [:current_password, :password, :password_confirmation]
 
-    if params.respond_to?(:permit)
-      params.require(resource_name).permit(*permitted_params)
-    else
-      params[scope].slice(*permitted_params)
-    end
+    params.require(resource_name).permit(*permitted_params)
   end
 
   def scope

test/controllers/test_password_expired_controller.rb

@@ -21,11 +21,35 @@ class Devise::PasswordExpiredControllerTest < ActionController::TestCase
     sign_in(@user)
   end
 
+  test 'redirects on show if user not logged in' do
+    sign_out(@user)
+    get :show
+    assert_redirected_to :root
+  end
+
+  test 'redirects on show if user does not need password change' do
+    @user.update(password_changed_at: Time.zone.now)
+    get :show
+    assert_redirected_to :root
+  end
+
   test 'should render show' do
     get :show
     assert_includes @response.body, 'Renew your password'
   end
 
+  test 'redirects on update if user not logged in' do
+    sign_out(@user)
+    put :update
+    assert_redirected_to :root
+  end
+
+  test 'redirects on update if user does not need password change' do
+    @user.update(password_changed_at: Time.zone.now)
+    put :update
+    assert_redirected_to :root
+  end
+
   test 'update password with default format' do
     if Rails.gem_version < Gem::Version.new('5.0')
       put :update,