Skip to content

Dockerize devito application #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2018
Merged

Dockerize devito application #558

merged 1 commit into from
May 2, 2018

Conversation

c-w
Copy link
Contributor

@c-w c-w commented May 1, 2018

Paired with @navjotk

@codecov-io
Copy link

codecov-io commented May 1, 2018 •
edited
Loading

Codecov Report

Merging #558 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   75.82%   75.82%           
=======================================
  Files          74       74           
  Lines        7021     7021           
  Branches     1427     1427           
=======================================
  Hits         5324     5324           
  Misses       1524     1524           
  Partials      173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93c002...099aa77. Read the comment docs.

FabioLuporini
FabioLuporini requested changes May 1, 2018
View reviewed changes
Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

I'll ask for some beta-testing on Slack

README.md Outdated
git clone https://github.com/opesci/devito.git
cd devito
conda env create -f environment.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both options should stay. Conda, in particular, should be the way to go for developers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would keep conda too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the introductory paragraph above only talks about conda

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I've restored the previous README state.

README.md Outdated
pip install -e .

# run tests
docker-compose run devito /tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this assumes the presence of docker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a link to the Docker documentation.

mloubout
mloubout requested changes May 1, 2018
View reviewed changes
Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine overall.
I still would prefer it to be added as an second option and keep the previous README as this one makes it look like Devito can only be run through Docker.

FabioLuporini
FabioLuporini approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm happy now. I'd like to wait a bit for some feedback from any of our own users/developers to double check that this works as expected.

@FabioLuporini
Copy link
Contributor

People are confirming that this does work as expected. @navjotk @mloubout @ggorman any other comments?

@navjotk
Copy link
Member

navjotk commented May 2, 2018

I like it. Waiting for @mloubout to update his review.

@FabioLuporini
Copy link
Contributor

Cool, merging.

@FabioLuporini FabioLuporini merged commit 9a7fc91 into devitocodes:master May 2, 2018
@FabioLuporini
Copy link
Contributor

Merged.

@c-w c-w deleted the dockerize branch May 2, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabioLuporini FabioLuporini FabioLuporini approved these changes

@mloubout mloubout mloubout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@c-w @codecov-io @FabioLuporini @navjotk @mloubout