Dockerize devito application#558
Conversation
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 75.82% 75.82%
=======================================
Files 74 74
Lines 7021 7021
Branches 1427 1427
=======================================
Hits 5324 5324
Misses 1524 1524
Partials 173 173Continue to review full report at Codecov.
|
FabioLuporini
left a comment
FabioLuporini
left a comment
There was a problem hiding this comment.
Thanks for this.
I'll ask for some beta-testing on Slack
| # get the code | ||
| git clone https://github.com/opesci/devito.git | ||
| cd devito | ||
| conda env create -f environment.yml |
There was a problem hiding this comment.
I think both options should stay. Conda, in particular, should be the way to go for developers.
There was a problem hiding this comment.
Also, the introductory paragraph above only talks about conda
There was a problem hiding this comment.
Sounds good. I've restored the previous README state.
| pip install -e . | ||
|
|
||
| # run tests | ||
| docker-compose run devito /tests |
There was a problem hiding this comment.
this assumes the presence of docker
There was a problem hiding this comment.
Added a link to the Docker documentation.
mloubout
left a comment
mloubout
left a comment
There was a problem hiding this comment.
Fine overall.
I still would prefer it to be added as an second option and keep the previous README as this one makes it look like Devito can only be run through Docker.
Paired with @navjotk
FabioLuporini
left a comment
FabioLuporini
left a comment
There was a problem hiding this comment.
OK, I'm happy now. I'd like to wait a bit for some feedback from any of our own users/developers to double check that this works as expected.
|
I like it. Waiting for @mloubout to update his review. |
|
Cool, merging. |
|
Merged. |
5 participants
Paired with @navjotk