Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce exposing of devon-ide scripts' variables to environment #5

Closed
markusschuh opened this issue Oct 3, 2018 · 1 comment
Closed
Labels
enhancement New feature or request scripts related to shell scripts (bash and CMD)
Milestone

Comments

@markusschuh
Copy link
Member

Category: Enhancement

Severity: Low

Description of expected enhancement: The current refactoring is a good opportunity to reduce the a bit too generous use of external environment variables by the IDE scripts a bit. Even when those variables are only defined within the workspace consoles - and everything what is started from there - there is a small risk of unnecessary side effects, when variables of local scope like "MODE" are exposed to outside.

hohwille added a commit that referenced this issue Dec 13, 2018
#5: removed unused WORKSPACE_REL_PATH, also removed dead or wrong comments (clean code)
hohwille added a commit that referenced this issue Dec 13, 2018
#5: export less variables
hohwille added a commit that referenced this issue Mar 11, 2019
…script confusion (#32)

* #30: fixed also renamed variable in update-eclipse-workspace-settings scripts

* #31: redesigned scripts for linux/Mac

#28: replaced env.sh with devon script and resolved CWD issue
#27: fixed PATH explosion
#5: reduce exported variables

* #31: further improvements

* #31: improved configurator, added vscode support

* #31: small improvement for IDE

* #31: small improvement for commands

* #31: changed groupId, added update command, fixed devon script

* #31: improvements and fixes (3rd party, license, commands)

* #31: added TERMS_OF_USE, fixed license naming bug, include sources, cleanup

* #31: massive improvements, automatic download and installation

* #31: devon-ide is going to rock the world

* #31: small improvements, fixed unzip command

* #31: again largely refactored and improved

* #31: fixed vscode, improved logging

* #31: various fixes and improvements, stated windows support

* #31: create only one scripts package for all platforms as we use bash on all platforms including windows now

* #31: fixed windows self installation

* #31: improvement for system path

* #27: fixed PATH expansion consistently for all platforms

* #31: removed obsolete scripts

* #31: fixed for whitespace in path, cleanups

* #31: fixed build

* #31: fixed gradle installer

* #31: fun with maven filtering

* #31: improve CLI, add archetype support

* #31: ups, fixed

* #31: prepare for beta release
@hohwille hohwille added this to the release:3.0.0 milestone Mar 11, 2019
@hohwille hohwille added enhancement New feature or request scripts related to shell scripts (bash and CMD) labels Mar 11, 2019
@hohwille
Copy link
Member

done.
Documentation can be found here:
https://github.com/devonfw/devon-ide/wiki/varibales

hohwille added a commit that referenced this issue Aug 23, 2019
#198: fixed power-shell look&feel issue
#213: fixed cygwin setup
#214: fixed usage documentation
#216: no symlinks for cygwin
#219 fixed undefined variables
#220: use mklink on windows
#5: reduced export
in Eclipse show also IDE folder name in titlebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scripts related to shell scripts (bash and CMD)
Projects
None yet
Development

No branches or pull requests

2 participants