Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in DevonNamingConventionClassExtendsClassUcImplCheck.isImplementingCorrectInterface #60

Closed
hohwille opened this issue Dec 17, 2019 · 1 comment

Comments

@hohwille
Copy link
Member

In PR #50 I found a small bug in DevonNamingConventionClassExtendsClassUcImplCheck.isImplementingCorrectInterface after merging:

protected boolean isImplementingCorrectInterface(String superInterface) {
    boolean isImplementingCorrectInterface = false;
    for (String name : this.superInterfacesNames) {
      if (superInterface.equals(name)) {
        return true;
      } else {
        return false;
      }
      isImplementingCorrectInterface = superInterface.equals(name);
    }
    return isImplementingCorrectInterface;
}

actually this was wrong before and still is wrong.
If superInterface.equals(name) is true this method should return true. Currently it only does if the expected interface is the last one.

@lmarniazman
Copy link
Member

Fixed with PR #63, can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants